Skip to content

added lazy sender initializer #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2018
Merged

added lazy sender initializer #132

merged 1 commit into from
Apr 11, 2018

Conversation

mastak
Copy link
Contributor

@mastak mastak commented Apr 11, 2018 •
edited
Loading

These changes provide the lazy initializer for the sender instance. It can help with issue with forked scripts like uwsgi:
http://uwsgi-docs.readthedocs.io/en/latest/ThingsToKnow.html

uWSGI tries to (ab)use the Copy On Write semantics of the fork() call whenever possible.
By default it will fork after having loaded your applications to share as much of their memory as possible.

So we should create Queue after fork.

PS Also, I faced this issue in celery and this fix helps me.

@mastak
added lazy sender initializer
4ebb946 
Signed-off-by: Ihor Liubymov <infunt@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6e51a47 on mastak:feature/lazy-sender into 268f577 on fluent:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6e51a47 on mastak:feature/lazy-sender into 268f577 on fluent:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6e51a47 on mastak:feature/lazy-sender into 268f577 on fluent:master.

@coveralls
Copy link

coveralls commented Apr 11, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4ebb946 on mastak:feature/lazy-sender into 268f577 on fluent:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6e51a47 on mastak:feature/lazy-sender into 268f577 on fluent:master.

@mastak mastak force-pushed the feature/lazy-sender branch from 6e51a47 to 4ebb946 Compare April 11, 2018 12:43
@arcivanov
Copy link
Member

Looks reasonable. Thanks!

@arcivanov arcivanov merged commit cf769b7 into fluent:master Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastak @coveralls @arcivanov