Skip to content

Conversation

quasipedia
Copy link
Contributor

This pull request fixes issue #23.

@quasipedia quasipedia force-pushed the bugfix/py3-recordformatter-incompatibility branch from 57f921a to 83794e0 Compare September 29, 2014 08:37
@quasipedia
Copy link
Contributor Author

Just a note: the latest commit changes the signature of the FluentRecordFormatter class to conform to regular Formatter classes provided by the standard library.

The user case scenario for which this is a good change is when configuring loggers using logging.config.dictConfig() in conjunction with a configuration dictionary. In this case, the formatter entry needs to be specified as:

'fluentd': {
    '()': fluent_handler.FluentRecordFormatter,
},

and the class with be automatically initialised passing fmt and datefmt as parameters).

The above applies to both python 2.7 and 3.x.

@EvaSDK
Copy link
Contributor

EvaSDK commented Jun 17, 2015

I think this PR can be closed as it should be covered by PR #18 that was merged in v0.4.0.

@repeatedly repeatedly closed this Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants