Asynchronous threaded support for senders and handlers. #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

repeatedly merged 4 commits into fluent:master from panta:feature/asynchronous-communication

Nov 10, 2017

Contributor

panta commented Nov 7, 2017

These decouple the logging from the actual sending, which is delegated to a separate dedicated thread.
This is useful in high-speed applications, where the network overhead is not (always) acceptable.
This also avoids the issues of the logging server not being reachable and leading to timeouts, with the corresponding huge slowdowns.

The asynchronous versions are entirely optional.
Full test suites are provided.


          Add support for asynchronous threaded sender and logging handler.

d9a7ab6

These are implemented respectively in asyncsender and asynchandler, with the same interfaces as their synchronous counterparts.

coveralls commented Nov 7, 2017 •

edited

Loading

Coverage increased (+0.04%) to 90.909% when pulling d9a7ab6 on panta:feature/asynchronous-communication into 0efc2fc on fluent:master.

1 similar comment

coveralls commented Nov 7, 2017 •

edited

Loading

Coverage increased (+0.04%) to 90.909% when pulling d9a7ab6 on panta:feature/asynchronous-communication into 0efc2fc on fluent:master.

Member

repeatedly commented Nov 9, 2017 •

edited

Loading

Could you update README about this feature?

repeatedly self-assigned this


          Import FluentRecordFormatter from asynchandler for to have the exact …

33e367f

…same interface as the regular handler module.

coveralls commented Nov 9, 2017 •

edited

Loading

Coverage increased (+0.3%) to 91.212% when pulling e66e4e3 on panta:feature/asynchronous-communication into 0efc2fc on fluent:master.

coveralls commented Nov 9, 2017 •

edited

Loading

Coverage increased (+0.3%) to 91.212% when pulling d920d71 on panta:feature/asynchronous-communication into 0efc2fc on fluent:master.

2 similar comments

coveralls commented Nov 9, 2017

Coverage increased (+0.3%) to 91.212% when pulling d920d71 on panta:feature/asynchronous-communication into 0efc2fc on fluent:master.

coveralls commented Nov 9, 2017

Coverage increased (+0.3%) to 91.212% when pulling d920d71 on panta:feature/asynchronous-communication into 0efc2fc on fluent:master.

panta added 2 commits

November 9, 2017 09:18


          Implement empty-queue timeout to avoid taxing the CPU.

ba91507


          Update README.rst with information on the asynchronous threaded commu…

25ecbda

…nication interface.

panta force-pushed the feature/asynchronous-communication branch from 3a3e97b to 25ecbda Compare

November 9, 2017 08:19

coveralls commented Nov 9, 2017 •

edited

Loading

Coverage increased (+0.3%) to 91.212% when pulling 25ecbda on panta:feature/asynchronous-communication into 66603f2 on fluent:master.

Contributor Author

panta commented Nov 9, 2017

I've updated the README, and also fixed an issue that made the communication thread heavy on the CPU.

coveralls commented Nov 9, 2017

Coverage increased (+0.3%) to 91.212% when pulling 25ecbda on panta:feature/asynchronous-communication into 66603f2 on fluent:master.

3 similar comments

coveralls commented Nov 9, 2017

Coverage increased (+0.3%) to 91.212% when pulling 25ecbda on panta:feature/asynchronous-communication into 66603f2 on fluent:master.

coveralls commented Nov 9, 2017

Coverage increased (+0.3%) to 91.212% when pulling 25ecbda on panta:feature/asynchronous-communication into 66603f2 on fluent:master.

coveralls commented Nov 9, 2017

Coverage increased (+0.3%) to 91.212% when pulling 25ecbda on panta:feature/asynchronous-communication into 66603f2 on fluent:master.

repeatedly merged commit 0d10c47 into fluent:master

Member

repeatedly commented Nov 10, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet