Skip to content

Don't create wrapper element in i18n component on Vue 3 #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Demivan opened this issue Oct 21, 2022 — with Volta.net · 0 comments · Fixed by #820
Closed

Don't create wrapper element in i18n component on Vue 3 #794

Demivan opened this issue Oct 21, 2022 — with Volta.net · 0 comments · Fixed by #820
Labels

Comments

Copy link
Member

Demivan commented Oct 21, 2022

Vue 3 does not require components to have a wrapper element.

It is possible to make i18n component to not render wrapper element by default on Vue 3.

Pros:

  • Simpler html structure by default

Cons:

  • Vue 3 implementation will be different from Vue 2
  • Adding classes and other attributes will not work by default

Or instead new attribute can be added or allow tag attribute to accept falsy values.
Pros:

  • Non-breaking change

Cons:

  • Could be to inconvenient to use this parameter everythere
  • This attribute will not work in Vue 2 anyway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant