Skip to content

Allow to not create wrapper element in i18n component #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 14, 2023
Merged

Conversation

Demivan
Copy link
Member

@Demivan Demivan commented Jun 14, 2023

Description

In Vue 3 components do not require a root HTML element.

This pull request allows passing :tag="false" or no-tag attributes, that disable creation of extra wrapper element.
Added componentTag configuration option that sets default value for tag attribute of i18n component.

Linked Issues

Fixes #794

Additional context

@github-actions
Copy link

github-actions bot commented Jun 14, 2023

Export Size

fluent-vue

Name Size Diff
createFluentVue 2.38 KB +118 B (+5.09%) 🔺
Unchanged

fluent-vue

Name Size Diff
useFluent 887 B -

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #820 (43e6934) into main (5bad1c4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
+ Coverage   98.97%   98.98%   +0.01%     
==========================================
  Files          12       12              
  Lines         195      197       +2     
  Branches       37       39       +2     
==========================================
+ Hits          193      195       +2     
  Partials        2        2              
Flag Coverage Δ
vue-2 91.87% <93.33%> (+0.08%) ⬆️
vue-3 90.86% <88.88%> (-0.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/util/options.ts 100.00% <100.00%> (ø)
src/vue/component.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Demivan Demivan added the Type: Feature Includes new features label Jun 14, 2023
@Demivan Demivan merged commit 0df3aa3 into main Jun 14, 2023
@Demivan Demivan deleted the vue-3-no-wrapper branch June 14, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Includes new features
Development

Successfully merging this pull request may close these issues.

Don't create wrapper element in i18n component on Vue 3
1 participant