Skip to content

Fix typing error which breaks app.use #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

hongquan
Copy link
Contributor

@hongquan hongquan commented Feb 16, 2023

Description

This PR is to fix typing error when calling Vue app.use

Linked Issues

Fixes #807

Additional context

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #808 (74c27ca) into main (fdc1fbc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #808   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files          12       12           
  Lines         191      191           
  Branches       33       33           
=======================================
  Hits          189      189           
  Partials        2        2           
Flag Coverage Δ
vue-2 91.62% <ø> (ø)
vue-3 91.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Demivan
Copy link
Member

Demivan commented Feb 16, 2023

Thanks for contribution. Will release in a moment.

@Demivan Demivan merged commit 55d0593 into fluent-vue:main Feb 16, 2023
@Demivan Demivan added the Type: Bug Something isn't working label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Typing error with app.use()
2 participants