Skip to content

Allow global functions, directive and component to be renamed #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

Flambe
Copy link
Contributor

@Flambe Flambe commented Feb 23, 2023

Description

Allows the user to rename the t & ta global functions & directive to avoid conflicts with other libraries.

Fixes #805

Linked Issues

#805

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #811 (ced7f39) into main (aa62b38) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
+ Coverage   98.95%   98.97%   +0.02%     
==========================================
  Files          12       12              
  Lines         191      195       +4     
  Branches       33       37       +4     
==========================================
+ Hits          189      193       +4     
  Partials        2        2              
Flag Coverage Δ
vue-2 91.79% <72.72%> (+0.17%) ⬆️
vue-3 91.79% <72.72%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

- split out renaming so that the user can individually rename the functions, directive and component
Copy link
Member

@Demivan Demivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution

@Demivan Demivan changed the title feat(options): allow t and ta globals and directive to be renamed feat: allow global functions, directive and component to be renamed Feb 24, 2023
@Demivan Demivan merged commit bc940be into fluent-vue:main Feb 24, 2023
@Demivan Demivan changed the title feat: allow global functions, directive and component to be renamed Allow global functions, directive and component to be renamed Feb 24, 2023
@Demivan Demivan added the Type: Feature Includes new features label Feb 24, 2023
@Flambe
Copy link
Contributor Author

Flambe commented Feb 24, 2023

Thank you for the great library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Includes new features
Development

Successfully merging this pull request may close these issues.

Migration path from vue-i18n to fluent-vue
3 participants