Add support for binding SSR props in Vue 3 directive #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export Sizefluent-vue
Unchangedfluent-vue
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bind localized element attributes on server side when using v-t directive.
Linked Issues
Needed for #695
Additional context
It only binds attributes, not the text content. This is a limitation of Vue 3, and binding text content will need to be done in the directive transform.
It does not use element type to check whether an attribute is localizable. This is a limitation of Vue 3. To combat potential issues, I have added a runtime warning when translation contains non-localizable attributes.