Skip to content

Improve compatibility with @nuxt/test-utils #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

Improve compatibility with @nuxt/test-utils #955

merged 1 commit into from
Aug 5, 2025

Conversation

Demivan
Copy link
Member

@Demivan Demivan commented Jul 28, 2025 •
edited
Loading

Description

@nuxt/test-utils are not correctly binding this in globalProperties functions. Resolve this by using getCurrentInstance() that should always be the current component.

Linked Issues

Fixes #954

Additional context

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

Export Size

fluent-vue

Name Size Diff
createFluentVue 4.13 KB +33 B (+0.79%) 🔺
Unchanged

fluent-vue

Name Size Diff
useFluent 961 B -

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 28, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/fluent-vue/fluent-vue@955

commit: d3e150e

@codecov Codecov
Copy link

codecov bot commented Jul 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.54%. Comparing base (ad128fb) to head (d3e150e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #955   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          12       12           
  Lines         218      220    +2     
  Branches       45       45           
=======================================
+ Hits          217      219    +2     
  Partials        1        1
Flag Coverage Δ
vue-2 87.72% <0.00%> (-0.81%) ⬇️
vue-3 92.27% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Demivan Demivan added the Type: Bug Something isn't working label Jul 28, 2025
@Demivan Demivan force-pushed the fix-nuxt-test-utils branch from 99278de to a6d8b62 Compare July 28, 2025 20:25
@Demivan Demivan changed the title Improve compatibilty with @nuxt/text-utils Improve compatibilty with @nuxt/test-utils Jul 28, 2025
@Demivan Demivan mentioned this pull request Jul 28, 2025
Closed
4 tasks
@Demivan Demivan changed the title Improve compatibilty with @nuxt/test-utils Improve compatibility with @nuxt/text-utils Jul 28, 2025
@Demivan Demivan force-pushed the fix-nuxt-test-utils branch from a6d8b62 to d3e150e Compare July 28, 2025 20:31
@ranisalt
Copy link

ranisalt commented Aug 4, 2025

There's a typo on the title (text instead of test) in case you use that for release notes

@Demivan Demivan changed the title Improve compatibility with @nuxt/text-utils Improve compatibility with @nuxt/test-utils Aug 5, 2025
@Demivan Demivan merged commit e520e40 into main Aug 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<fluent> blocks not processed during testing
2 participants
@Demivan @ranisalt