Skip to content

Update SkSL bundle format #55219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonahwilliams opened this issue Apr 20, 2020 · 2 comments · Fixed by flutter/engine#17861
Closed

Update SkSL bundle format #55219

jonahwilliams opened this issue Apr 20, 2020 · 2 comments · Fixed by flutter/engine#17861
Assignees
@liyuqian
Labels
engine flutter/engine repository. See also e: labels.

Comments

@jonahwilliams
Copy link
Member

Current the SkSL format returned by the VM service _getSkSL is a map of base32 encoded file names to base64 encoded contents. Rather than trying to unpack these into a directory structure for the flutter assets, it would be easiest if this JSON blob could simply be placed directly in the assets.

This simplifies the bundling process and allows it to work on windows without long paths enabled

@liyuqian
@jonahwilliams jonahwilliams added the engine flutter/engine repository. See also e: labels. label Apr 20, 2020
@liyuqian liyuqian mentioned this issue Apr 20, 2020
Closed
8 tasks
@liyuqian liyuqian self-assigned this Apr 20, 2020
liyuqian added a commit to liyuqian/engine that referenced this issue Apr 22, 2020
@liyuqian
Read SkSL from json asset
406608f 
Fixes flutter/flutter#55219
@liyuqian liyuqian mentioned this issue Apr 22, 2020
Merged
liyuqian added a commit to flutter/engine that referenced this issue Apr 22, 2020
@liyuqian
Read SkSL from json asset (#17861)
31ecf87 
Fixes flutter/flutter#55219
@jonahwilliams
Copy link
Member Author

Thanks @liyuqian , I'll pick this up again once the engine rolls

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@liyuqian liyuqian

Labels
engine flutter/engine repository. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Read SkSL from json asset liyuqian/engine
2 participants
@jonahwilliams @liyuqian