-
Notifications
You must be signed in to change notification settings - Fork 28.7k
"flutter packages pub ..." to passthrough to dart pub #10044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why not just |
Fixes #9799 |
|
Fixes #9301 |
So you would do commands such as |
@mit-mit I think it'd be fine to also expose explicit commands (the way e.g. I added I'm also rather dubious of taking on the maintenance burden of having to track |
I don't think we have added any new commands in for quite a while (maybe several years), so not sure I'm too worried about that. |
@@ -67,5 +66,105 @@ void main() { | |||
expectExists(projectPath, 'lib/main.dart'); | |||
expectExists(projectPath, '.packages'); | |||
}); | |||
}, skip: true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why skip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops. I was testing the other one and forgot to remove this. Fixed.
Why not make a dedicated |
Changing the behaviour of |
If we want to change this to |
Discussing with @Hixie, we'll likely to need a dedicated |
LGTM |
cc @tvolkert