Remove semantics boundary from gesture detector AND MORE #13983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aedeb13 to
0f60f9f
Compare
0f60f9f to
d813328
Compare
|
|
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly. Fixes flutter#12589. Fixes flutter#11991. See also flutter#11993. This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand. In addition, the following minor changes are included in this PR: * Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`. * Logic optimizations for `markNeedsSemanticsUpdate` . * Fix for edge case where `MergeSemantics` failed to merge semantics. * Use of emojis to better indicate leaf merging in the printed semantics tree. * Better assert message for adding invisible child semantics nodes. * Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries. Fixes flutter#13943.
iskakaushik
pushed a commit
to iskakaushik/flutter
that referenced
this pull request
Nov 23, 2019
Following commits: 584d958 (HEAD -> master, upstream/master) [fuchsia] Capture SkRRect in scene_update_context by value (flutter#13989) 0f530a7 Roll src/third_party/skia 078e8faa26d8..47af12aa8331 (22 commits) (flutter#13987) 97a23a8 Made a way to turn off the OpenGL operations on the IO thread for backgrounded apps (flutter#13908) 0d60e1a Do not default to downstream affinity on iOS insertText (flutter#13852) 9c68366 Added auto-reviewer config file (flutter#13962) a5f4290 Roll fuchsia/sdk/core/linux-amd64 from mvesW... to _7JyV... (flutter#13983) 69f94a5 Roll src/third_party/dart 029e06b8d9..5b5f34f2e6 (10 commits) (flutter#13982)
iskakaushik
added a commit
that referenced
this pull request
Nov 23, 2019
584d958 (HEAD -> master, upstream/master) [fuchsia] Capture SkRRect in scene_update_context by value (#13989) 0f530a7 Roll src/third_party/skia 078e8faa26d8..47af12aa8331 (22 commits) (#13987) 97a23a8 Made a way to turn off the OpenGL operations on the IO thread for backgrounded apps (#13908) 0d60e1a Do not default to downstream affinity on iOS insertText (#13852) 9c68366 Added auto-reviewer config file (#13962) a5f4290 Roll fuchsia/sdk/core/linux-amd64 from mvesW... to _7JyV... (#13983) 69f94a5 Roll src/third_party/dart 029e06b8d9..5b5f34f2e6 (10 commits) (#13982)
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RenderSemanticsGestureHandleris no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly.Fixes #12589.
Fixes #11991.
See also #11993.
This change also required some refactoring to how we deal with
twoPaneSemanticsscrolling as it previously relied onRenderSemanticsGestureHandlerbeing a semantics boundary. This should also make the underlying logic easier to understand.In addition, the following minor changes are included in this PR:
SemanticsConfiguration.isMergingDescendantsIntoOneNode.markNeedsSemanticsUpdate.MergeSemanticsfailed to merge semantics.Fixes #13943.