Provide isolate id for rpc request to ensure they are run on correct (UI) thread. #17616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
May 15, 2018
aam
added a commit
to aam/flutter
that referenced
this pull request
May 17, 2018
…correct (UI) thread. (flutter#17616)" This reverts commit 89cb5d2 as it broke matchers_test.
|
This coincides with a significant regression in some benchmarks. e.g., |
|
cc @tvolkert Interesting side-note regarding your investigations: this coincides with a massive improvement on the hot restart benchmark. Maybe this PR changed the accounting? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works together with flutter/engine#5263 and goes towards fixing #17434