Enable --sync-async in Flutter. #17866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mravn-google
approved these changes
May 24, 2018
| await new Future.microtask(() {}); | ||
| // When the test had an exception, the test-framework already | ||
| // ran the teardown functions, removing the _fakeAsync function. | ||
| if (_fakeAsync == null) return; |
There was a problem hiding this comment.
This return statement and the one below are inconsistent; one returns something, the other does not.
mravn-google
added a commit
that referenced
this pull request
May 24, 2018
This reverts commit 39d7f22.
mravn-google
added a commit
that referenced
this pull request
May 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the --sync-async flag for Flutter.
Also fixes the flutter-test package, updates a test (which has a different stacktrace now), and completes one test (where one line wasn't hit before).