Remove flaky marker on some tests. #17882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They've been mostly green since flutter#17812
yjbanov
approved these changes
May 24, 2018
|
|
cbracken
reviewed
May 24, 2018
| @@ -199,7 +199,6 @@ tasks: | |||
| Runs end-to-end Flutter tests on Android. | |||
| stage: devicelab | |||
| required_agent_capabilities: ["mac/android"] | |||
| flaky: true | |||
There was a problem hiding this comment.
Note for future archaeologists: the flakiness appears to have ended coincidentally with the re-imaging of all the devicelab bots. I suspect this is still flaky and/or dependent on a race condition.
There was a problem hiding this comment.
Though looking at that commit - I could very much believe that it's also related to the service event handling fix.
There was a problem hiding this comment.
Three of these were definitely the service event handling fix. One was already green in the whole dashboard.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They've been mostly green since #17812