Fully rename to hot restart #17897
Merged
Fully rename to hot restart #17897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up change to f48dec5
devoncarew
approved these changes
May 25, 2018
| @@ -717,9 +717,9 @@ class HotRunner extends ResidentRunner { | |||
| const String bold = '\u001B[0;1m'; | |||
| const String reset = '\u001B[0m'; | |||
| printStatus( | |||
| '$fire To hot reload your app on the fly, press "r". To restart the app entirely, press "R".', | |||
| '$fire To hot reload your app on the fly, press "r". To hot restart the app, press "R".', | |||
There was a problem hiding this comment.
Given how close the names are, is it worth trying to differentiate what the two actions do here?
To hot reload changes into your app, press "r". To hot restart the app, press "R".
There was a problem hiding this comment.
How about this?
To hot reload changes while running, press "r". To hot restart and rebuild state, press "R".
There was a problem hiding this comment.
To hot reload changes while running, press "r". To hot restart (and rebuild state), press "R".?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up change to f48dec5