Add process output for flutter_tester test and unskip #18868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok; I'm gonna land this and just revert it if/when it fails. Hopefully it'll fail and we'll get some stdout; but if not nothing lost (except a brief period of potentially broken build). |
|
#18871 is ready to revert this change if it fails. |
DanTup
added a commit
that referenced
this pull request
Jun 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test failed after I commit my "new tests" (which slightly refactored this code, but not in any way I can imagine would cause the failure). It failed because flutter_tester didn't remain alive (a bug we'd had previously, and specifically added this test for), however only on
mac_bot; bot on Travis, AppVeyor or locally. I marked it as skip to get the build green, but I'd like to get to the bottom of it.This test adds any stdout/stderr to the error message in case there are clues there (maybe it crashed?), however the only way to test this out is probably to merge and let it run on
mac_botagain (this means merging something that will probably break the build, and then reverting it once it's run).@devoncarew