Provide a list of Material design primary and accent color swatches #2714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
collinjackson
added a commit
that referenced
this pull request
Mar 15, 2016
Provide a list of Material design primary and accent color swatches
|
cc @HansMuller There's some code in the gallery that can be simplified now that this exists. |
| orange, | ||
| deepOrange, | ||
| brown, | ||
| // grey intentionally omitted |
There was a problem hiding this comment.
@collinjackson Do you remember why you omitted grey here?
There was a problem hiding this comment.
Grey seemed like a special case, because it's sort of a "colorless color" and Colors.grey array contains more levels than the other primaries. The particular use case I was solving for was picking a random Material color, and I didn't want something to look disabled, and Colors.primaries.where((c) c != Colors.grey) seemed a bit verbose. But that said, I can see a valid argument for leaving grey in -- it's fine by me either way.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.