Skip to content

Cupertino localization step 4: let generated date localization combine material and cupertino locales #29650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2019
Merged

Cupertino localization step 4: let generated date localization combine material and cupertino locales #29650

merged 5 commits into from
Apr 3, 2019

Conversation

xster
Copy link
Member

@xster xster commented Mar 20, 2019 •
edited
Loading

Description

Diffbase xster/flutter@localization-2...xster:localization-3

Makes sure the dates stuff also includes cupertino locales.

Related Issues

#13452

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@xster xster requested a review from HansMuller March 20, 2019 01:51
@xster xster changed the title Localization 3 Cupertino localization step 3: let generated date localization combine material and cupertino locales Mar 20, 2019
@xster xster changed the title Cupertino localization step 3: let generated date localization combine material and cupertino locales Cupertino localization step 4: let generated date localization combine material and cupertino locales Mar 20, 2019
@goderbauer goderbauer added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Mar 20, 2019
HansMuller
HansMuller approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xster xster merged commit 72a4083 into flutter:master Apr 3, 2019
@xster xster deleted the localization-3 branch April 3, 2019 01:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xster @HansMuller @goderbauer @googlebot