Disable macOS integration tests #31216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.cirrus.yml
Outdated
| # - name: $SHARD-macos | ||
| # env: | ||
| # matrix: | ||
| # - SHARD: integration_tests |
There was a problem hiding this comment.
Don't you just want to comment out this one line? Commenting out all of it will turn off all macos tests, not just the integration tests.
gspencergoog
approved these changes
Apr 17, 2019
| @@ -195,7 +195,7 @@ task: | |||
| - name: $SHARD-macos | |||
| env: | |||
| matrix: | |||
| - SHARD: integration_tests | |||
| # - SHARD: integration_tests | |||
There was a problem hiding this comment.
Maybe add a comment with a TODO about why it's commented out?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This task is currently flaking 3-4 times on every presubmit. We're disabling this until we know why.
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?