Skip to content

Use engine's getWordBoundary method when user selects a word. #3851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2016
Merged

Use engine's getWordBoundary method when user selects a word. #3851

merged 1 commit into from
May 12, 2016

Conversation

mpcomplete
Copy link
Contributor

No description provided.

@mpcomplete
Copy link
Contributor Author

Depends on flutter/engine#2675 .

@Hixie
Copy link
Contributor

Hixie commented May 11, 2016

LGTM once you've revved engine.
Please contact chinmay and jason before revving engine, there's been a bunch of changes and it isn't obvious whether it's safe to rev right now.

@abarth
Copy link
Contributor

abarth commented May 12, 2016

@Hixie We could potentially use this as a TextOverflow behavior (elide at word boundaries).

@mpcomplete mpcomplete merged commit 03141c2 into flutter:master May 12, 2016
@mpcomplete mpcomplete deleted the getWordBoundary branch May 12, 2016 19:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@abarth abarth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpcomplete @Hixie @abarth