Enable targetting AOTC Android builds from Mac hosts. #3911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| return <List<String>>[<String>['mac_debug', 'mac_debug/artifacts.zip']]; | ||
| return <List<String>>[ | ||
| <String>['darwin-x64', 'darwin-x64/artifacts.zip'], | ||
| <String>['android-arm-profile/darwin-x64', 'android-arm-profile/darwin-x64.zip'], |
There was a problem hiding this comment.
Confused as to why we have this additional layer of mapping from bucket names to on-disk names. But it's OK too.
|
Done & Rebased. Update the revision cooking on the bot. Its not done yet. Will commit once the tests pass.
Just replicated linux paths below. Will clean it up in a subsequent patch. |
|
Bots done and travis is green. Landing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @yjbanov, @jason-simmons, @sethladd
Will land once the bots settle down at 053630d