Use the correct host toolchain when building from a local engine checkout on Mac. #3956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you leave a comment about why Mac is special here? |
|
lgtm |
The toolchain are just named differently on Mac vs Linux. There is no such inconsistency with the buckets. This is just because we are grabbing stuff directly out of the build directory. Before we have had a chance to homogenize the names and locations. We could also change the names of the toolchains themselves. But that would involve changing some GN files from Chromium. |
|
Ok. If we end up with a bunch of these we'll want to centralize this kind of configuration. But OK. This one tiny option is way nicer than the giant pile of paths we hardcoded before :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jason-simmons