[flutter_tools] Report iOS mDNS lookup failures to analytics #41384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
tvolkert
approved these changes
Sep 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #41384 +/- ##
==========================================
+ Coverage 60.07% 60.21% +0.14%
==========================================
Files 193 193
Lines 18751 18753 +2
==========================================
+ Hits 11265 11293 +28
+ Misses 7486 7460 -26
Continue to review full report at Codecov.
|
|
Can you add a test that we properly report these analytics events? |
|
Will post a PR with unit tests in a few minutes. |
2 tasks
|
Test here: #41410 |
tvolkert
pushed a commit
to tvolkert/flutter
that referenced
this pull request
Sep 27, 2019
Merged
tvolkert
added a commit
that referenced
this pull request
Sep 27, 2019
* [flutter_tools] Report iOS mDNS lookup failures to analytics (#41384) * [flutter_tools] Adds tests of mdns analytics events (#41410) * [flutter_tool] Add analytics events for ios-mdns fallback success/failure (#41482) * roll ideviceinstaller, libimobiledevice, libplist, openssl & usbmuxd to signed versions (#41411)
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're getting reports that mDNS lookups are failing on iOS. This PR adds some analytics events to get a better idea of the severity of the issue.
Related Issues
#41085
Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?