Skip to content

Reland handle corrupt config file #45414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 22, 2019
Merged

Reland handle corrupt config file #45414

merged 3 commits into from
Nov 22, 2019

Conversation

jonahwilliams
Copy link
Member

Description

If the JSON file is corrupted don't crash when parsing

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 22, 2019
christopherfujino
christopherfujino approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@xster
Copy link
Member

xster commented Nov 22, 2019

LGTM

@jonahwilliams jonahwilliams merged commit c63c576 into flutter:master Nov 22, 2019
@jonahwilliams jonahwilliams deleted the handle_corrupt_config branch November 22, 2019 21:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonahwilliams @xster @christopherfujino @googlebot @fluttergithubbot