Skip to content

Drops detached message until we can handle it properly #45430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2019
Merged

Drops detached message until we can handle it properly #45430

merged 2 commits into from
Nov 23, 2019

Conversation

chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Nov 22, 2019 •
edited
Loading

Description

Engine add to app starts sending detached message to framework. However, framework side change is pending on desktop embedding.
This pr drops the detached message as a workaround to unblock stable release.

Related Issues

#45575

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 22, 2019
@chunhtai chunhtai requested a review from xster November 22, 2019 22:41
@xster
Copy link
Member

xster commented Nov 22, 2019

I'd add something to binding_test.dart. There are existing scaffolds for testing this

@xster
Copy link
Member

xster commented Nov 23, 2019

LGTM

@chunhtai chunhtai merged commit f15f69a into flutter:master Nov 23, 2019
chunhtai added a commit to chunhtai/flutter that referenced this pull request Jan 9, 2020
@chunhtai
Revert "Drops detached message until we can handle it properly (flutt…
ffb14f5 
…er#45430)"

This reverts commit f15f69a.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xster xster Awaiting requested review from xster

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chunhtai @fluttergithubbot @xster @googlebot