Skip to content

v1.12.13+hotfix.8 cherry-picks - gradle upgrades #50489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2020
Merged

v1.12.13+hotfix.8 cherry-picks - gradle upgrades #50489

merged 3 commits into from
Feb 10, 2020

Conversation

christopherfujino
Copy link
Contributor

Description

This cherry-picks commits from #50388 (upgrade Gradle) in order to get CI tests to pass. These changes are infra-only, and should not affect end-users.

Tests

These changes are to get tests (specifically firebase testlab) passing on the hotfix branch.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@fluttergithubbot
Copy link
Contributor

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to v1.12.13-hotfixes. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

@fluttergithubbot fluttergithubbot changed the base branch from v1.12.13-hotfixes to master February 10, 2020 19:52
@fluttergithubbot fluttergithubbot added engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 10, 2020
@christopherfujino christopherfujino changed the title Hotfix gradle upgrades v1.12.13+hotfix.8 cherry-picks - gradle upgrades Feb 10, 2020
@christopherfujino christopherfujino changed the base branch from master to v1.12.13-hotfixes February 10, 2020 19:52
dnfield
dnfield approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino merged commit 4e0c970 into flutter:v1.12.13-hotfixes Feb 10, 2020
@christopherfujino christopherfujino deleted the hotfix-gradle-upgrades branch February 10, 2020 22:29
@christopherfujino christopherfujino mentioned this pull request Feb 11, 2020
Closed
responilla07 pushed a commit to responilla07/flutter that referenced this pull request Jun 8, 2020
@christopherfujino @responilla07
v1.12.13+hotfix.8 cherry-picks - gradle upgrades (flutter#50489)
5bc2e9f
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dnfield dnfield dnfield approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christopherfujino @fluttergithubbot @dnfield @googlebot