Inject Usage dependency into FallbackDiscovery and BuildEvent #53443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Mar 27, 2020
| @@ -132,16 +132,14 @@ void main() { | |||
| ), | |||
| ); | |||
|
|
|||
| await diagnoseXcodeBuildFailure(buildResult); | |||
| await diagnoseXcodeBuildFailure(buildResult, mockUsage, logger); | |||
There was a problem hiding this comment.
These tests still hit the context.
| Future<VmService> Function(String wsUri, {Log log}) vmServiceConnectUri = | ||
| vm_service_io.vmServiceConnectUri, | ||
| }) : _logger = logger, | ||
| _mDnsObservatoryDiscovery = mDnsObservatoryDiscovery, | ||
| _portForwarder = portForwarder, | ||
| _protocolDiscovery = protocolDiscovery, | ||
| _flutterUsage = flutterUsage, |
There was a problem hiding this comment.
Suggested change
| _flutterUsage = flutterUsage, | |
| _flutterUsage = flutterUsage, |
| @@ -48,6 +48,7 @@ void main() { | |||
| platform: platform, | |||
| processManager: processManager, | |||
| terminal: terminal, | |||
| usage: null, | |||
There was a problem hiding this comment.
In the future we'll likely want to make these non-nullable. Consider creating a FlutterUsage.test() which can be created at low cost to avoid explicitly passing null
|
Oh, and an analyzer error: |
0b3b425 to
7ca010f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inject Usage into FallbackDiscovery and BuildEvent.
Convert fallback_discovery_test.dart to testWithoutContext
Related Issues
#47161
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change