-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[flutter_tools] re-enable debug extension #53765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_tools] re-enable debug extension #53765
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Is the error here when using VS Code, or command line? If VS Code, this won't work yet because it's using SSE and in VS Code we don't support using SSE (for the VM service proxy). I have a Flutter branch that passes through a flag through to dwds to tell it not to use SSE but it doesn't rebase cleanly with the recent changes so I need to fix it up before I can open a PR. Is there a way to test this is being set correctly to ensure it doesn't regress? (a previous test is here but I don't know how easily adaptable it is after the changes). |
Yeah from VS Code, command line works okay. Since that is expected I will adapt a test today |
FWIW, I applied this fix to my Flutter branch and ran it with my VS Code branch to test. I was able to launch the Gallery using web-server, click the extension button, and have it resume and hit a breakpoint 👍 I'll do some testing on GitPod, and if it still works there, I'll open a PR with the changes to force WebSockets (instead of SSE) for review/discussion. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Gonna use this to kick the build |
Description
I accidentally disabled this when migrating to the latest dwds/compiler updates.
@DanTup I wasn't able to get the this to work from vs code, though the command line works okay. I get an
net::ERR_CONNECTION_REFUSE
from SSE on the browser side and then the extension goes down. also fyi @grouma