Skip to content

[flutter_tools] re-enable debug extension #53765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2020

Conversation

jonahwilliams
Copy link
Member

Description

I accidentally disabled this when migrating to the latest dwds/compiler updates.

@DanTup I wasn't able to get the this to work from vs code, though the command line works okay. I get an net::ERR_CONNECTION_REFUSE from SSE on the browser side and then the extension goes down. also fyi @grouma

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 1, 2020
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@DanTup
Copy link
Contributor

DanTup commented Apr 2, 2020

@DanTup I wasn't able to get the this to work from vs code, though the command line works okay. I get an net::ERR_CONNECTION_REFUSE from SSE on the browser side and then the extension goes down.

Is the error here when using VS Code, or command line? If VS Code, this won't work yet because it's using SSE and in VS Code we don't support using SSE (for the VM service proxy). I have a Flutter branch that passes through a flag through to dwds to tell it not to use SSE but it doesn't rebase cleanly with the recent changes so I need to fix it up before I can open a PR.

Is there a way to test this is being set correctly to ensure it doesn't regress? (a previous test is here but I don't know how easily adaptable it is after the changes).

@jonahwilliams
Copy link
Member Author

Yeah from VS Code, command line works okay. Since that is expected I will adapt a test today

@DanTup
Copy link
Contributor

DanTup commented Apr 3, 2020

FWIW, I applied this fix to my Flutter branch and ran it with my VS Code branch to test. I was able to launch the Gallery using web-server, click the extension button, and have it resume and hit a breakpoint 👍

Screenshot 2020-04-03 at 11 04 07

I'll do some testing on GitPod, and if it still works there, I'll open a PR with the changes to force WebSockets (instead of SSE) for review/discussion.

Thanks!

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams
Copy link
Member Author

Gonna use this to kick the build

@jonahwilliams jonahwilliams merged commit 1e86c1f into flutter:master Apr 3, 2020
@jonahwilliams jonahwilliams deleted the web-server-start-paused branch April 3, 2020 20:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants