Skip to content

Add error message about missing unzip utility #55315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Add error message about missing unzip utility #55315

merged 1 commit into from
Apr 23, 2020

Conversation

TrueBers
Copy link
Contributor

Otherwise, if unzip has not been installed before the SDK update process, we get a message about corrupted archive, even if it's not corrupted.

Otherwise, if `unzip` has not been installed before the SDK update process, we get a message about corrupted archive, even if it's not corrupted.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@TrueBers
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 22, 2020
@christopherfujino
Copy link
Contributor

Thanks so much for this. I thought this had been fixed, but it appears not :P

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member

jmagman commented Apr 23, 2020

Tree is green, all Cirrus tasks passed https://cirrus-ci.com/build/6260122330595328, not sure why it's not updating. Merging.

@jmagman jmagman merged commit 9f92ec2 into flutter:master Apr 23, 2020
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants