-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Add error message about missing unzip utility #55315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Otherwise, if `unzip` has not been installed before the SDK update process, we get a message about corrupted archive, even if it's not corrupted.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks so much for this. I thought this had been fixed, but it appears not :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tree is green, all Cirrus tasks passed https://cirrus-ci.com/build/6260122330595328, not sure why it's not updating. Merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Otherwise, if
unzip
has not been installed before the SDK update process, we get a message about corrupted archive, even if it's not corrupted.