Skip to content

Fix InputDecorator intrinsic height reporting #55408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2020
Merged

Fix InputDecorator intrinsic height reporting #55408

merged 2 commits into from
Apr 22, 2020

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Apr 22, 2020 •
edited
Loading

Description

This fixes the intrinsic height reported by InputDecorator to account for the kMinInteractiveDimension when appropriate.

Related Issues

Fixes #54729

Tests

Checks against overflow exceptions when the InputDecorator.isDense is true and false to validate correct intrinsics.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@Piinks Piinks added a: text input Entering text in a text field or keyboard related problems c: regression It was better in the past than it is now framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. labels Apr 22, 2020
@Piinks Piinks requested a review from justinmc April 22, 2020 22:03
justinmc
justinmc approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for identifying and fixing this!

@fluttergithubbot fluttergithubbot merged commit e74fedc into flutter:master Apr 22, 2020
@justinmc justinmc mentioned this pull request Apr 23, 2020
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinmc justinmc justinmc approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems c: regression It was better in the past than it is now f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SliverFillRemaining Widget creates overflow with TextFields
4 participants
@Piinks @justinmc @googlebot @fluttergithubbot