Skip to content

Use androidSdk globals variable everywhere #56330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2020
Merged

Use androidSdk globals variable everywhere #56330

merged 1 commit into from
May 5, 2020

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented May 4, 2020

Description

Remove androidSdk from android_sdk.dart, use existing globals.androidSdk everywhere.

Related Issues

Part of #47161

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 4, 2020
@jmagman jmagman self-assigned this May 4, 2020
@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label May 4, 2020
@jmagman jmagman requested a review from christopherfujino May 4, 2020 22:20
christopherfujino
christopherfujino approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, LGTM

@jmagman
Copy link
Member Author

jmagman commented May 5, 2020

Merging on red to kick LUCI

@jmagman jmagman merged commit c587d73 into flutter:master May 5, 2020
@jmagman jmagman deleted the android-sdk-global branch May 5, 2020 00:48
@jmagman jmagman mentioned this pull request May 5, 2020
Merged
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees

@jmagman jmagman

Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmagman @christopherfujino @googlebot