Send text error in JSON and print in tools #58284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -187,6 +190,7 @@ class FlutterDevice { | |||
| CompileExpression compileExpression, | |||
| ReloadMethod reloadMethod, | |||
| GetSkSLMethod getSkSLMethod, | |||
| PrintErrorEventMethod printErrorEventMethod, | |||
There was a problem hiding this comment.
This needs to be hooked up somewhere to work, are either of the Hot/Cold runners passing this through?
There was a problem hiding this comment.
They both call connectToServiceProtocol defined on ResidentRunner in their attach methods, so that should mean they use the printErrorEventMethod defined on ResidentRunner too. Are there other places that need to pass in a print method too?
jacob314
reviewed
Jun 2, 2020
jacob314
reviewed
Jun 2, 2020
jacob314
reviewed
Jun 2, 2020
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
packages/flutter_tools/test/general.shard/resident_web_runner_test.dart
Outdated
Show resolved
Hide resolved
jonahwilliams
added a commit
that referenced
this pull request
Jun 6, 2020
This reverts commit cce6b3c.
jonahwilliams
added a commit
that referenced
this pull request
Jun 6, 2020
helin24
added a commit
to helin24/flutter
that referenced
this pull request
Jun 8, 2020
…8284)" (flutter#58872)" This reverts commit c2d5e18.
helin24
added a commit
that referenced
this pull request
Jun 8, 2020
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
* Revert "Revert "Send text error in JSON and print in tools (flutter#58284)" (flutter#58872)" This reverts commit c2d5e18. * Put streamListen in try/catch if extension events already listened for
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
* Send text error in JSON and print in tools * Add test for error text * Fix analysis issues * Move streamListen to try/catch and use global.printStatus * Extract print error fn and listen for events in web runner * Add extension listen request to test * Update packages/flutter_tools/lib/src/resident_runner.dart Co-authored-by: Jonah Williams <jonahwilliams@google.com> * Rename error parsing method * Allow crash if listen for extension stream fails * Add test for error and non-error extension events * Fix formatting for TextTreeRenderer * Use shorter message for second exceptions * Specify types for map * Add empty JSON for resident_web_runner test * Move stream listen to vmservice and add vmservice test * Fix stream type * Move structured error log definition to vmservice * Use correct test matcher isNot Co-authored-by: Jonah Williams <jonahwilliams@google.com>
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…lutter#58872) This reverts commit cce6b3c.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
* Revert "Revert "Send text error in JSON and print in tools (flutter#58284)" (flutter#58872)" This reverts commit c2d5e18. * Put streamListen in try/catch if extension events already listened for
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to #58118.
Currently, calling
flutter run --dart-define=flutter.inspector.structuredErrors=trueon the command line will result in errors not being printed because they are captured as structured errors and sent out as JSON. This change lets flutter_tools display the text of errors.Result if running on phone emulator:
Result if running application on web:
Related Issues
None
Tests
I added the following tests:
resident_web_runnerlistens for extension eventsChecklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.