[flutter_tools] write sksl on exit #58743
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -111,7 +114,11 @@ class DriveCommand extends RunCommandBase { | |||
| 'Works only if \'browser-name\' is set to \'android-chrome\'') | |||
| ..addOption('chrome-binary', | |||
| help: 'Location of Chrome binary. ' | |||
| 'Works only if \'browser-name\' is set to \'chrome\''); | |||
| 'Works only if \'browser-name\' is set to \'chrome\'') | |||
There was a problem hiding this comment.
@liyuqian would it be easier if the command required you to pass in a destination file?
like --write-sksl-on-exit=foo.sksl.json ?
There was a problem hiding this comment.
That sounds good to me. It also makes my test easier as I don't have to worry about whether the tool will create sksl_02.json or sksl_01.json. With --write-sksl-on-exit=foo.sksl.json , I'd expect the file to be overwritten, right?
|
SG, I added a trivial unit test - your benchmark could be the integration test |
Description
Allow dumping sksl files on driver exit when a file path is provided to drive's --write-sksl-on-exit
Fixes #54484