-
Notifications
You must be signed in to change notification settings - Fork 28.7k
make flutter create less chatty #6197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What's the output after this patch? |
@pq - example output with patch
|
Thanks! IMO that's a little "too" minimal. When @devoncarew suggested:
I took that more to mean summarizing some of the big subdirs. I still think links to things like the main entry point ( I'll defer to @devoncarew for his 2 cents though. |
IMO listing the major directories or anything like that provides little incremental value at extra flutter_tools code complexity. The user will likely open the project in their IDE of choice and see the project structure there. |
I'm not sure... But then I don't know the motivations for adding it in the first place! :)
Maybe. But there are always going to be folks that prefer the CLI and we should make the experience there as nice as possible. |
I agree that we want a nice CLI experience. IMO the other information that we print during |
Honestly I'd consider even silencing the The one thing I'd say about the file listing is that it did give new users a sense of what was where, which is nice. They might not think to look at the directory structure, but if it's right there it's hard to miss. We probably don't need to list every last PNG though. Should we maybe silence the One thing regardless of the above is that we should put a new line before the "All done". Right now it reads like it's part of the last paragraph of the |
I agree w/ the code complexity angle. At the same time, it's nice to give some sense of how much work we did, and an sketch of the project that was generated. Perhaps thats:
and
|
Merged into #6213 |
Fixes #6191
@pq