Manually filter old android device log messages instead of relying on the '-T' option #6630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| DateTime time = _adbTimestampToDateTime(timestamp); | ||
| if (time.isBefore(_timeOrigin)) { | ||
| // Ignore log messages before the origin. | ||
| printTrace('skipped old log line: $line'); |
There was a problem hiding this comment.
Do these need to be printed? Users can see them at any time by running logcat
There was a problem hiding this comment.
I'm just being consistent with the existing behaviour: log messages that are ignored are still printed via printTrace. See the bottom of this function.
There was a problem hiding this comment.
I added this yesterday. May have been a mistake. Feel free to remove that.
| @@ -249,7 +249,13 @@ class HotRunner extends ResidentRunner { | |||
| } | |||
|
|
|||
| _observatoryPort = result.observatoryPort; | |||
| await connectToServiceProtocol(_observatoryPort); | |||
| try { | |||
There was a problem hiding this comment.
Move this to a separate PR?
There was a problem hiding this comment.
This belongs in this PR because it fixes the error message when we fall over detecting the service protocol port.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Galaxy Note 5 (#6280)