Skip to content

Added an option to allow default fonts to not be packed in an flx file. #6710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2016

Conversation

pylaligand
Copy link
Contributor

@pylaligand pylaligand commented Nov 4, 2016

Default fonts should never be bundled on Fuchsia.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@pylaligand
Copy link
Contributor Author

/cc @kulakowski

@googlebot
Copy link

CLAs look good, thanks!

@abarth
Copy link
Contributor

abarth commented Nov 4, 2016

LGTM

@abarth
Copy link
Contributor

abarth commented Nov 4, 2016

/cc @jason-simmons

@Hixie
Copy link
Contributor

Hixie commented Nov 4, 2016

How will you do custom fonts on Fuchsia then?

@pylaligand
Copy link
Contributor Author

This really applies only to default fonts that Flutter normally caches and adds. From the look of it adding a font in the manifest should still work.

@Hixie
Copy link
Contributor

Hixie commented Nov 4, 2016

How is this different from "includeRobotoFonts" then?

@abarth
Copy link
Contributor

abarth commented Nov 4, 2016

Previously we included roboto on iOS but not on Android. We included the material design icons everywhere. Perhaps we should have a flag that controls the material design icons specifically.

@pylaligand
Copy link
Contributor Author

I changed the flag to be specifically about fonts that Flutter would normally cache itself - new patch coming up soon.

@pylaligand pylaligand changed the title Added an option to allow fonts to not be packed in an flx file. Added an option to allow default fonts to not be packed in an flx file. Nov 4, 2016
@Hixie
Copy link
Contributor

Hixie commented Nov 4, 2016

Presumably we do want to pack the Material Design Icons file. That file gets revved, and it's critical that the app run with the version it expects.

In fact honestly I'd say the same about Roboto. Why would the app want to rely on the system fonts?

@abarth
Copy link
Contributor

abarth commented Nov 4, 2016

Why would the app want to rely on the system fonts?

Because the system fonts have been arranged to correspond exactly with the app's needs because the app builds together with the system.

@Hixie
Copy link
Contributor

Hixie commented Nov 4, 2016

Ah, well, ok, in that one specific case... :-P

@pylaligand pylaligand merged commit 9b7764d into flutter:master Nov 4, 2016
@pylaligand pylaligand deleted the fonts branch November 4, 2016 21:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants