-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Added an option to allow default fonts to not be packed in an flx file. #6710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
/cc @kulakowski |
CLAs look good, thanks! |
/cc @jason-simmons |
How will you do custom fonts on Fuchsia then? |
This really applies only to default fonts that Flutter normally caches and adds. From the look of it adding a font in the manifest should still work. |
How is this different from "includeRobotoFonts" then? |
Previously we included roboto on iOS but not on Android. We included the material design icons everywhere. Perhaps we should have a flag that controls the material design icons specifically. |
I changed the flag to be specifically about fonts that Flutter would normally cache itself - new patch coming up soon. |
Fonts should never be bundled on Fuchsia.
Presumably we do want to pack the Material Design Icons file. That file gets revved, and it's critical that the app run with the version it expects. In fact honestly I'd say the same about Roboto. Why would the app want to rely on the system fonts? |
Because the system fonts have been arranged to correspond exactly with the app's needs because the app builds together with the system. |
Ah, well, ok, in that one specific case... :-P |
Default fonts should never be bundled on Fuchsia.