Skip to content

Add some dartdoc to basic widgets #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2015
Merged

Conversation

abarth
Copy link
Contributor

@abarth abarth commented Dec 7, 2015

These docs are largely duplicated from the cooresponding rendering classes. I'm
not sure how we can avoid repeating ourselves.

@abarth
Copy link
Contributor Author

abarth commented Dec 7, 2015

@Hixie

@@ -572,6 +572,7 @@ abstract class _RenderCustomClip<T> extends RenderProxyBox {
CustomClipper<T> clipper
}) : _clipper = clipper, super(child);

/// If non-null, determines which chip to use on the child.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clip, not chip

@Hixie
Copy link
Contributor

Hixie commented Dec 7, 2015

LGTM

These docs are largely duplicated from the cooresponding rendering classes. I'm
not sure how we can avoid repeating ourselves.
abarth added a commit that referenced this pull request Dec 7, 2015
Add some dartdoc to basic widgets
@abarth abarth merged commit 73e62d3 into flutter:master Dec 7, 2015
@abarth abarth deleted the basic_docs branch December 7, 2015 18:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants