Disable menu button when bottom sheet open #8319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise tapping the menu button causes the bottom sheet to disappear and reappear. Fixes flutter#8275
|
LGTM |
|
Isn't this papering over a framework bug? |
|
What's the intended behavior when you open a persistent bottom sheet when you already have one? I'd expect the old one to animate out and the new one to animate in. That's what eric describes as "dancing" |
|
Oh clicking the button just brings up the bottom sheet, rather than a popup menu? Never mind, I misunderstood. |
|
Correct |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise tapping the menu button causes the bottom sheet to disappear and
reappear.
Fixes #8275