Skip to content

Enforce didUpdateWidget() @mustCallSuper #9421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2017
Merged

Enforce didUpdateWidget() @mustCallSuper #9421

merged 1 commit into from
Apr 17, 2017

Conversation

HansMuller
Copy link
Contributor

Did this TODO

  /// If you override this, make sure your method starts with a call to
  /// super.didUpdateWidget(oldWidget).
  // TODO(abarth): Add @mustCallSuper.
  @protected
  void didUpdateWidget(covariant T oldWidget) { }

@abarth
Copy link
Contributor

abarth commented Apr 17, 2017

LGTM

@HansMuller HansMuller merged commit d05d361 into flutter:master Apr 17, 2017
@Hixie
Copy link
Contributor

Hixie commented Apr 17, 2017

NICE

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HansMuller @abarth @Hixie @googlebot