Skip to content

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented May 8, 2017

Upgrade to most recent version of android build tools, version 25.0.3: https://developer.android.com/studio/releases/build-tools.html

This provides some temporary relief for #8438

@mit-mit mit-mit requested a review from jakobr-google May 8, 2017 12:47
Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented May 8, 2017

Is there no way to automatically use the latest version?

@mit-mit
Copy link
Member Author

mit-mit commented May 8, 2017

No, the version is pinned to the exact version stated in the file.

@mit-mit mit-mit merged commit 5ed2984 into flutter:master May 8, 2017
@mit-mit mit-mit deleted the upgradetoolsversion branch May 8, 2017 18:12
mit-mit added a commit that referenced this pull request May 8, 2017
mit-mit added a commit that referenced this pull request May 8, 2017
@Hixie
Copy link
Contributor

Hixie commented May 8, 2017

@mit-mit would it make sense for us to detect what the latest installed version is and automatically update the build files at build time to use those, or something? Or maybe make "flutter upgrade" upgrade the user to use the latest SDK?

It seems very odd for us to pin people to a specific version when they run "flutter create". They're not going to know that they have to update it. We're going to regularly forget to update it for all out examples. If the version in our examples doesn't match the version their app uses now they have to use two versions. Or maybe they'll download us then download the SDK and get a later version than we expect and now we won't work. In general this seems like a poor experience.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants