Improve error messages from slivers. #9971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarth
reviewed
May 10, 2017
| final double paintExtent = math.min( | ||
| beforePaddingPaintExtent + math.max(childLayoutGeometry.paintExtent, childLayoutGeometry.layoutExtent + afterPaddingPaintExtent), | ||
| constraints.remainingPaintExtent, | ||
| ); |
There was a problem hiding this comment.
Is this part of the change testable?
There was a problem hiding this comment.
Previously, the layoutExtent would occasionally (due to floating point math) end up slightly bigger than the paintExtent. That prevents that from happening. I don't know how to actually cause it to happen. It was intermittently happening on that flickering dropdown test you saw me look at.
I'm happy to add a test if you have any ideas for how to actually reproduce the problem reliably.
|
LGTM w/ test if the padding change is observable. |
|
Fixes #8378 |
Also, fix some logic in SliverPadding.
|
landing on red because redness was a transient error on the windows bot |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix some logic in SliverPadding.