Skip to content

[in_app_purchase] Update in_app_purchase_storekit version in in_app_purchase #9786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nikunjrCybage
Copy link
Contributor

Description:
This PR updates the in_app_purchase_storekit dependency to 0.4.4 in the in_app_purchase package and its example app.
This keeps the StoreKit implementation in sync with the latest release, ensuring compatibility with recent changes and improvements.

Notes:

  • test-exempt: rolling dependencies

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences].
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I marked this PR as test-exempt since it is a dependency roll.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the in_app_purchase_storekit dependency to version 0.4.4 and bumps the package version accordingly. The changes are consistent across the package and its example. I have one suggestion to make the changelog entry more descriptive for users by including the key feature introduced in the dependency update.

@@ -2,6 +2,9 @@

* Updates minimum supported SDK version to Flutter 3.27/Dart 3.6.

## 3.2.4
* Updates minimum `in_app_purchase_storekit` version to 0.4.4.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This changelog entry is correct but not very descriptive. To help users understand the value of this update, it would be beneficial to summarize the key changes from the new in_app_purchase_storekit version.

Version 0.4.4 of in_app_purchase_storekit adds support for specifying quantity for consumable purchases on iOS. I recommend including this information in the changelog for better clarity.

Suggested change
* Updates minimum `in_app_purchase_storekit` version to 0.4.4.
* Updates `in_app_purchase_storekit` to `0.4.4`, which adds support for specifying quantity for consumable purchases on iOS.

@stuartmorgan-g
Copy link
Contributor

ensuring compatibility with recent changes

What is the compatibility issue you are referring to here?

Absent a compelling reason, a roll like this is against our policy.

@stuartmorgan-g
Copy link
Contributor

FYI for the future, you don't give yourself a test exemption:

Notes:

  • test-exempt: rolling dependencies

This is a comment that needs to be left by one of the designated test exemption reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants