Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Add a gestureRecognizers parameter to GoogleMap. #755

Merged
merged 2 commits into from
Sep 6, 2018
Merged

Add a gestureRecognizers parameter to GoogleMap. #755

merged 2 commits into from
Sep 6, 2018

Conversation

amirh
Copy link
Contributor

@amirh amirh commented Sep 1, 2018

These gesture recognizers participates in gesture arenas on behalf of
the map.
This allows fine grain control over which gestures are dispatched to
the map.

@amirh amirh requested a review from bparrishMines September 1, 2018 02:41
@amirh amirh force-pushed the map_gestures branch 2 times, most recently from d5c0b9e to b8d4cce Compare September 1, 2018 04:42
@amirh
Add a gestureRecognizers parameter to GoogleMap.
4f77b7e 
These gesture recognizers participates in gesture arenas on behalf of
the map.
This allows fine grain control over which gestures are dispatched to
the map.
@amirh amirh mentioned this pull request Sep 1, 2018
Merged
bparrishMines
bparrishMines approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirh
Copy link
Contributor Author

amirh commented Sep 6, 2018

Thanks!
I ended up adding EagerGestureRecognizers in the framework (flutter/flutter#21407),
I'll wait for that PR to land first, and switch the example to use the framework's EagerGestureRecognizer before landing.

@amirh amirh merged commit 9d0e880 into flutter:master Sep 6, 2018
@amirh amirh deleted the map_gestures branch September 6, 2018 20:18
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
@amirh @andreidiaconu
Add a gestureRecognizers parameter to GoogleMap. (flutter#755)
d70b455 
These gesture recognizers participates in gesture arenas on behalf of
the map.
This allows fine grain control over which gestures are dispatched to
the map.
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
@andreidiaconu
Revert "Add a gestureRecognizers parameter to GoogleMap. (flutter#755)"
285e059 
This reverts commit d70b455.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@bparrishMines bparrishMines bparrishMines approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amirh @bparrishMines @googlebot