Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/feature extractor cleanup #117

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Feat/feature extractor cleanup #117

merged 4 commits into from
Nov 10, 2023

Conversation

MathieuCayssol
Copy link
Collaborator

@MathieuCayssol MathieuCayssol commented Nov 10, 2023 •
edited
Loading

Small details update:

  • Fix format issue in the unit tests
  • Add NotImplemented in case the pl.Expr is not implemented everywhere
  • Comment out benford_correlation2

@vercel Vercel
Copy link

vercel bot commented Nov 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 7:08pm

@MathieuCayssol MathieuCayssol marked this pull request as ready for review November 10, 2023 18:56
@abstractqqq abstractqqq merged commit 99bdcaa into main Nov 10, 2023
@abstractqqq abstractqqq deleted the feat/feature-extractor-cleanup branch November 10, 2023 19:26
topher-lo pushed a commit that referenced this pull request Dec 19, 2023
@MathieuCayssol
Feat/feature extractor cleanup (#117)
d07deb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abstractqqq abstractqqq abstractqqq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MathieuCayssol @abstractqqq