feat(fractional_differencing): create frac diff plugin #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transformer implementation of frac diff was also replaced with the plugin implementation. The api did not change however.
baggiponte
reviewed
Dec 20, 2023
baggiponte
requested changes
Dec 20, 2023
|
I agree. Let's add one test and have this approved. The error in test code is interesting though: I don't think this is related to this PR. But does anybody know what is aeon? |
So there were already tests here from the previous implementation. They still pass. Do you want me to write an explicit test for the plugin? The transformer that uses the plugin is tested |
It's a fork of functime. |
|
LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transformer implementation of frac diff was also replaced with the plugin implementation. The api did not change however.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Fractional differencing plugin
Any other comments?