Add simple tsfresh unit tests #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
variation_coefficient. feat: Add unit tests for - var_gt_std - large_standard_deviation - variation_coefficient - count_range
with variation_coefficient
for ruff pre-commit
for not series in variation_coefficient
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
and abs mean change
|
A series needs to differentiate between an int and float mean, whereas DataFrame/LazyFrame doesn't appear to. I think it could be related to pola-rs/polars#11736. But 0.0 == 0 returns True anyway I would push for returning nan for 0/0, and inf/-inf for |
Integrate Mathieu's proposal for handling zero mean in variation_coefficient. Co-authored-by: Mathieu Cayssol <49449000+MathieuCayssol@users.noreply.github.com>
Integrate Mathieu's proposal to update unit tests for zero mean in variation_coefficient. Co-authored-by: Mathieu Cayssol <49449000+MathieuCayssol@users.noreply.github.com>
topher-lo
pushed a commit
that referenced
this pull request
Dec 19, 2023
Co-authored-by: Mathieu Cayssol <49449000+MathieuCayssol@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests
Changes to tsfresh variation_coefficient function
also of note: Polars is limiting the significant figures with this function (I don't recall exactly, but this may be a local setting which can be changed).
Miscellaneous
Added a noqa on the second test_percent_reocurring_value test name - ruff pre-commit hook wasn't happy with it.
This looks like a lot of changes, but most of it is pre-commit reformatting.
Start at green line 58. (I use flake8 lint on save usually, but have turned that off now).