Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plotting.plot_entities #98

Merged
merged 3 commits into from
Oct 25, 2023
Merged

feat: add plotting.plot_entities #98

merged 3 commits into from
Oct 25, 2023

Conversation

baggiponte
Copy link
Collaborator

Solves #83. Also forces plotly white theme on plots!

Is this plot enough, or should I add more?

I plan to add separate functions to rank series by CV (e.g. a scatterplot for CV and a rank_cv function as mentioned in #84).

@baggiponte baggiponte added enhancement New feature or request plotting Plotting features labels Oct 24, 2023
@baggiponte baggiponte requested a review from topher-lo October 24, 2023 22:59
@baggiponte baggiponte self-assigned this Oct 24, 2023
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 2:12pm

@topher-lo
Copy link
Contributor

@baggiponte could you add a screenshot of the plot for context? Thanks!

@baggiponte
Copy link
Collaborator Author

baggiponte commented Oct 25, 2023

@baggiponte could you add a screenshot of the plot for context? Thanks!

Sure, it's the first plot you find in this notebook:

newplot

functime/plotting.py Outdated Show resolved Hide resolved
@topher-lo topher-lo marked this pull request as ready for review October 25, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plotting Plotting features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants