Skip to content

Basic JPMS (modules) support through 'Automatic-Module-Name' #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 3, 2019
Merged

Basic JPMS (modules) support through 'Automatic-Module-Name' #392

merged 3 commits into from
Nov 3, 2019

Conversation

gneuvill
Copy link
Member

@gneuvill gneuvill commented Oct 28, 2019 •
edited
Loading

Currently, having the 'functionaljava_1.8' jar on the classpath of a jvm version 9 or above is problematic since the module name automatically derived by either javac or the vm is broken. This P.R fixes this.

Whole modules declaration (module-info.java) should happen on the 5.x branch, I think.

@gneuvill gneuvill requested review from jbgi and mperry October 28, 2019 17:24
@codecov-io
Copy link

codecov-io commented Oct 29, 2019 •
edited
Loading

Codecov Report

Merging #392 into series/4.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             series/4.x    #392      +/-   ##
===============================================
+ Coverage         48.39%   48.4%   +0.01%     
- Complexity         2254    2255       +1     
===============================================
  Files               153     153              
  Lines              9063    9063              
  Branches            478     478              
===============================================
+ Hits               4386    4387       +1     
  Misses             4530    4530              
+ Partials            147     146       -1
Impacted Files Coverage Δ Complexity Δ
core/src/main/java/fj/data/Set.java 83.24% <0%> (+0.55%) 102% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcff9d1...5769934. Read the comment docs.

gliptak
gliptak reviewed Oct 29, 2019
View reviewed changes
@gliptak
Copy link
Contributor

gliptak commented Oct 29, 2019

@gneuvill please update the PR with the error you are seeing

@jbgi
Copy link
Member

jbgi commented Nov 2, 2019 •
edited
Loading

@gneuvill Could we use this instead: https://github.com/java9-modularity/gradle-modules-plugin#separate-compilation-of-module-infojava
?

@gliptak
Copy link
Contributor

gliptak commented Nov 3, 2019

@gneuvill Could we use this instead: https://github.com/java9-modularity/gradle-modules-plugin#separate-compilation-of-module-infojava
?

For above page shows "This plugin requires JDK 11 to be used when running Gradle." so Travis build might need to be reorganized

@jbgi jbgi merged commit de992c3 into series/4.x Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gliptak gliptak gliptak left review comments

@jbgi jbgi jbgi approved these changes

@mperry mperry Awaiting requested review from mperry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gneuvill @codecov-io @gliptak @jbgi