Skip to content

refactor: use JetBrains release repository for FernFlower decompiler #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2025
Merged

refactor: use JetBrains release repository for FernFlower decompiler #628

merged 3 commits into from
Jan 20, 2025

Conversation

AlexandrosAlexiou
Copy link
Contributor

This PR introduces the capability to fetch the FernFlower package from the JetBrains repository since they distribute it as a separate package, rather than including it in the git repository as a jar file.

Advantages:

  • Version Management: Easier to update and specify exact versions.
  • Reduced Project Size: Keeps the project lightweight by avoiding bundling the library.
  • Build Tool Compatibility: Simplifies integration with Gradle.
  • Separation of Concerns: Keeps project code and third-party libraries modular and distinct.

@github-actions github-actions bot added the build Related to the language server's own build (including Gradle updates etc.) label Jan 20, 2025
@AlexandrosAlexiou AlexandrosAlexiou force-pushed the refactor/dependecies/decompiler branch from c178571 to 688bd88 Compare January 20, 2025 18:43
@AlexandrosAlexiou AlexandrosAlexiou force-pushed the refactor/dependecies/decompiler branch 3 times, most recently from 5506004 to 9fb2d20 Compare January 20, 2025 19:29
@AlexandrosAlexiou AlexandrosAlexiou force-pushed the refactor/dependecies/decompiler branch from 9fb2d20 to 6cf3dac Compare January 20, 2025 19:43
@fwcd
Copy link
Owner

fwcd commented Jan 20, 2025

Looks reasonable, thanks!

@fwcd fwcd merged commit dc24041 into fwcd:main Jan 20, 2025
11 checks passed
Decodetalkers pushed a commit to Decodetalkers/kotlin-language-server that referenced this pull request Jan 21, 2025
@fwcd @Decodetalkers
Merge pull request fwcd#628 from AlexandrosAlexiou/refactor/dependeci…
b5a976a 
…es/decompiler

refactor: use JetBrains release repository for FernFlower decompiler
Decodetalkers pushed a commit to Decodetalkers/kotlin-language-server that referenced this pull request Jan 21, 2025
@fwcd @Decodetalkers
Merge pull request fwcd#628 from AlexandrosAlexiou/refactor/dependeci…
9035968 
…es/decompiler

refactor: use JetBrains release repository for FernFlower decompiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Related to the language server's own build (including Gradle updates etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandrosAlexiou @fwcd